stevenoh0908/mastodon-sakyey
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Convert admin/accounts controller->request specs (#37727)

Browse Source
This commit is contained in:
Matt Jankowski
2026-02-04 05:42:34 -05:00
committed by GitHub
parent a7aa52c7ef
commit 4f99b48e8e
2 changed files with 256 additions and 123 deletions
Download Patch File Download Diff File Expand all files Collapse all files

123
spec/controllers/admin/accounts_controller_spec.rb
View File

@@ -109,15 +109,6 @@ RSpec.describe Admin::AccountsController do
context 'when user is admin' do
let(:current_role) { UserRole.find_by(name: 'Admin') }
context 'when target user is admin' do
let(:target_role) { UserRole.find_by(name: 'Admin') }
it 'fails to memorialize account' do
expect(subject).to have_http_status 403
expect(account.reload).to_not be_memorial
end
end
context 'when target user is not admin' do
let(:target_role) { UserRole.find_by(name: 'Moderator') }
@@ -127,28 +118,6 @@ RSpec.describe Admin::AccountsController do
end
end
end
context 'when user is not admin' do
let(:current_role) { UserRole.find_by(name: 'Moderator') }
context 'when target user is admin' do
let(:target_role) { UserRole.find_by(name: 'Admin') }
it 'fails to memorialize account' do
expect(subject).to have_http_status 403
expect(account.reload).to_not be_memorial
end
end
context 'when target user is not admin' do
let(:target_role) { UserRole.find_by(name: 'Moderator') }
it 'fails to memorialize account' do
expect(subject).to have_http_status 403
expect(account.reload).to_not be_memorial
end
end
end
end
describe 'POST #enable' do
@@ -166,15 +135,6 @@ RSpec.describe Admin::AccountsController do
expect(user.reload).to_not be_disabled
end
end
context 'when user is not admin' do
let(:role) { UserRole.everyone }
it 'fails to enable account' do
expect(subject).to have_http_status 403
expect(user.reload).to be_disabled
end
end
end
describe 'POST #approve' do
@@ -204,15 +164,6 @@ RSpec.describe Admin::AccountsController do
)
end
end
context 'when user is not admin' do
let(:role) { UserRole.everyone }
it 'fails to approve account' do
expect(subject).to have_http_status 403
expect(user.reload).to_not be_approved
end
end
end
describe 'POST #reject' do
@@ -241,15 +192,6 @@ RSpec.describe Admin::AccountsController do
)
end
end
context 'when user is not admin' do
let(:role) { UserRole.everyone }
it 'fails to reject account' do
expect(subject).to have_http_status 403
expect(user.reload).to_not be_approved
end
end
end
describe 'POST #redownload' do
@@ -270,14 +212,6 @@ RSpec.describe Admin::AccountsController do
expect(subject).to redirect_to admin_account_path(account.id)
end
end
context 'when user is not admin' do
let(:role) { UserRole.everyone }
it 'fails to redownload' do
expect(subject).to have_http_status 403
end
end
end
describe 'POST #remove_avatar' do
@@ -293,14 +227,6 @@ RSpec.describe Admin::AccountsController do
expect(subject).to redirect_to admin_account_path(account.id)
end
end
context 'when user is not admin' do
let(:role) { UserRole.everyone }
it 'fails to remove avatar' do
expect(subject).to have_http_status 403
end
end
end
describe 'POST #unblock_email' do
@@ -322,15 +248,6 @@ RSpec.describe Admin::AccountsController do
expect(response).to redirect_to admin_account_path(account.id)
end
end
context 'when user is not admin' do
let(:role) { UserRole.everyone }
it 'fails to remove avatar' do
subject
expect(response).to have_http_status 403
end
end
end
describe 'POST #unsensitive' do
@@ -349,16 +266,6 @@ RSpec.describe Admin::AccountsController do
expect(response).to redirect_to admin_account_path(account.id)
end
end
context 'when user is not admin' do
let(:role) { UserRole.everyone }
it 'fails to change account' do
subject
expect(response).to have_http_status 403
end
end
end
describe 'POST #unsilence' do
@@ -377,16 +284,6 @@ RSpec.describe Admin::AccountsController do
expect(response).to redirect_to admin_account_path(account.id)
end
end
context 'when user is not admin' do
let(:role) { UserRole.everyone }
it 'fails to change account' do
subject
expect(response).to have_http_status 403
end
end
end
describe 'POST #unsuspend' do
@@ -409,16 +306,6 @@ RSpec.describe Admin::AccountsController do
expect(response).to redirect_to admin_account_path(account.id)
end
end
context 'when user is not admin' do
let(:role) { UserRole.everyone }
it 'fails to change account' do
subject
expect(response).to have_http_status 403
end
end
end
describe 'POST #destroy' do
@@ -445,16 +332,6 @@ RSpec.describe Admin::AccountsController do
expect(response).to redirect_to admin_account_path(account.id)
end
end
context 'when user is not admin' do
let(:role) { UserRole.everyone }
it 'fails to change account' do
subject
expect(response).to have_http_status 403
end
end
end
private

256
spec/requests/admin/accounts_spec.rb
View File

@@ -13,4 +13,260 @@ RSpec.describe 'Admin Accounts' do
.to redirect_to(admin_accounts_path)
end
end
describe 'POST /admin/accounts/:id/enable' do
let(:account) { user.account }
let(:user) { Fabricate(:user, disabled: true) }
context 'when user is not admin' do
let(:current_user) { Fabricate(:user, role: UserRole.everyone) }
before { sign_in current_user }
it 'fails to enable account' do
post enable_admin_account_path(id: account.id)
expect(response)
.to have_http_status(403)
expect(user.reload)
.to be_disabled
end
end
end
describe 'POST /admin/accounts/:id/approve' do
let(:account) { user.account }
let(:user) { Fabricate(:user) }
before { account.user.update(approved: false) }
context 'when user is not admin' do
let(:current_user) { Fabricate(:user, role: UserRole.everyone) }
before { sign_in current_user }
it 'fails to approve account' do
post approve_admin_account_path(id: account.id)
expect(response)
.to have_http_status(403)
expect(user.reload)
.to_not be_approved
end
end
end
describe 'POST /admin/accounts/:id/reject' do
let(:account) { user.account }
let(:user) { Fabricate(:user) }
before { account.user.update(approved: false) }
context 'when user is not admin' do
let(:current_user) { Fabricate(:user, role: UserRole.everyone) }
it 'fails to reject account' do
post reject_admin_account_path(id: account.id)
expect(response)
.to have_http_status(403)
expect(user.reload)
.to_not be_approved
end
end
end
describe 'POST /admin/accounts/:id/redownload' do
let(:account) { Fabricate(:account, domain: 'example.com', last_webfingered_at: 10.days.ago) }
let(:service) { instance_double(ResolveAccountService, call: nil) }
before { allow(ResolveAccountService).to receive(:new).and_return(service) }
context 'when user is not admin' do
let(:current_user) { Fabricate(:user, role: UserRole.everyone) }
it 'fails to redownload' do
post redownload_admin_account_path(id: account.id)
expect(response)
.to have_http_status(403)
expect(account.reload.last_webfingered_at)
.to_not be_nil
end
end
end
describe 'POST /admin/accounts/:id/remove_avatar' do
let(:account) { Fabricate(:account) }
context 'when user is not admin' do
let(:current_user) { Fabricate(:user, role: UserRole.everyone) }
it 'fails to remove avatar' do
expect { post remove_avatar_admin_account_path(id: account.id) }
.to_not change(Admin::ActionLog.where(action: 'remove_avatar'), :count)
expect(response)
.to have_http_status(403)
end
end
end
describe 'POST /admin/accounts/:id/remove_header' do
let(:account) { Fabricate(:account) }
context 'when user is not admin' do
let(:current_user) { Fabricate(:user, role: UserRole.everyone) }
it 'fails to remove header' do
expect { post remove_header_admin_account_path(id: account.id) }
.to_not change(Admin::ActionLog.where(action: 'remove_header'), :count)
expect(response)
.to have_http_status(403)
end
end
end
describe 'POST /admin/accounts/:id/unblock_email' do
let(:account) { Fabricate(:account, suspended: true) }
before { Fabricate(:canonical_email_block, reference_account: account) }
context 'when user is not admin' do
let(:current_user) { Fabricate(:user, role: UserRole.everyone) }
it 'fails to unblock email' do
expect { post unblock_email_admin_account_path(id: account.id) }
.to_not change(CanonicalEmailBlock.where(reference_account: account), :count)
expect(response)
.to have_http_status(403)
end
end
end
describe 'POST /admin/accounts/:id/unsensitive' do
let(:account) { Fabricate(:account, sensitized_at: 1.year.ago) }
context 'when user is not admin' do
let(:current_user) { Fabricate(:user, role: UserRole.everyone) }
it 'fails to unsensitive account' do
post unsensitive_admin_account_path(id: account.id)
expect(response)
.to have_http_status(403)
expect(account)
.to be_sensitized
end
end
end
describe 'POST /admin/accounts/:id/unsilence' do
let(:account) { Fabricate(:account, silenced_at: 1.year.ago) }
context 'when user is not admin' do
let(:current_user) { Fabricate(:user, role: UserRole.everyone) }
it 'fails to unsilence account' do
post unsilence_admin_account_path(id: account.id)
expect(response)
.to have_http_status(403)
expect(account)
.to be_silenced
end
end
end
describe 'POST /admin/accounts/:id/unsuspend' do
let(:account) { Fabricate(:account) }
before { account.suspend! }
context 'when user is not admin' do
let(:current_user) { Fabricate(:user, role: UserRole.everyone) }
it 'fails to unsuspend account' do
post unsuspend_admin_account_path(id: account.id)
expect(response)
.to have_http_status(403)
expect(account)
.to be_suspended
end
end
end
describe 'DELETE /admin/accounts/:id' do
let(:account) { Fabricate(:account) }
before { account.suspend! }
context 'when user is not admin' do
let(:current_user) { Fabricate(:user, role: UserRole.everyone) }
it 'fails to delete account' do
delete admin_account_path(id: account.id)
expect(response)
.to have_http_status(403)
expect { account.reload }
.to_not raise_error
end
end
end
describe 'POST /admin/accounts/:id/memorialize' do
let(:account) { user.account }
let(:user) { Fabricate(:user, role: target_role) }
context 'when user is admin' do
let(:current_user) { Fabricate(:admin_user) }
context 'when target user is admin' do
let(:target_role) { UserRole.find_by(name: 'Admin') }
it 'fails to memorialize account' do
post memorialize_admin_account_path(id: account.id)
expect(response)
.to have_http_status(403)
expect(account.reload)
.to_not be_memorial
end
end
end
context 'when user is not admin' do
let(:current_user) { Fabricate(:moderator_user) }
context 'when target user is admin' do
let(:target_role) { UserRole.find_by(name: 'Admin') }
it 'fails to memorialize account' do
post memorialize_admin_account_path(id: account.id)
expect(response)
.to have_http_status(403)
expect(account.reload)
.to_not be_memorial
end
end
context 'when target user is not admin' do
let(:target_role) { UserRole.find_by(name: 'Moderator') }
it 'fails to memorialize account' do
post memorialize_admin_account_path(id: account.id)
expect(response)
.to have_http_status(403)
expect(account.reload)
.to_not be_memorial
end
end
end
end
end