From e92b7beb7555aad2c10c840d951b4dcf5d3900b6 Mon Sep 17 00:00:00 2001
From: Matt Jankowski <matt@jankowski.online>
Date: Fri, 27 Feb 2026 10:23:48 -0500
Subject: [PATCH] Refactor tests for `FeaturedTag#display_name` (#38007)

---
 spec/models/featured_tag_spec.rb | 20 +++++++++-----------
 1 file changed, 9 insertions(+), 11 deletions(-)

diff --git a/spec/models/featured_tag_spec.rb b/spec/models/featured_tag_spec.rb
index 1197776b02..b0a994aaf1 100644
--- a/spec/models/featured_tag_spec.rb
+++ b/spec/models/featured_tag_spec.rb
@@ -93,24 +93,22 @@ RSpec.describe FeaturedTag do
   end
 
   describe '#display_name' do
-    subject { Fabricate.build :featured_tag, name: name, tag: tag }
+    subject { featured_tag.display_name }
 
-    context 'with a name value present' do
-      let(:name) { 'Test' }
+    let(:featured_tag) { Fabricate.build :featured_tag, name: name, tag: tag }
+
+    context 'with a name value present on the featured tag' do
+      let(:name) { 'FeaturedTagName' }
       let(:tag) { nil }
 
-      it 'uses name value' do
-        expect(subject.display_name).to eq('Test')
-      end
+      it { is_expected.to eq('FeaturedTagName') }
     end
 
-    context 'with a missing name value but a present tag' do
+    context 'with a missing name value but a present linked tag' do
       let(:name) { nil }
-      let(:tag) { Fabricate.build :tag, name: 'Tester' }
+      let(:tag) { Fabricate.build :tag, display_name: 'LinkedTagDisplayName' }
 
-      it 'uses name value' do
-        expect(subject.display_name).to eq('Tester')
-      end
+      it { is_expected.to eq('LinkedTagDisplayName') }
     end
   end